Fixes #issue18098 SectionList scrollToLocation #21577
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
Import Started
|
Thank you for this PR. |
cpojer
force-pushed
the
bug-sectionlist-scrolltolocation
branch
from
d3cf10c
to
3e82f11
Compare
melina7890
requested review from
hramos,
janicduplessis,
mhorowitz and
shergin
as code owners
| @@ -145,7 +146,7 @@ class VirtualizedSectionList<SectionT: SectionBase> extends React.PureComponent< | |||
| sectionIndex: number, | |||
| viewPosition?: number, | |||
| }) { | |||
| let index = params.itemIndex + 1; | |||
There was a problem hiding this comment.
prettier/prettier: Replace ?·params.itemIndex with ·?·params.itemIndex·
| @@ -145,7 +146,7 @@ class VirtualizedSectionList<SectionT: SectionBase> extends React.PureComponent< | |||
| sectionIndex: number, | |||
| viewPosition?: number, | |||
| }) { | |||
| let index = params.itemIndex + 1; | |||
There was a problem hiding this comment.
space-infix-ops: Infix operators must be spaced.
| @@ -10,6 +10,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const React = require('React'); | |||
| const Platform = require('../Utilities/Platform'); | |||
There was a problem hiding this comment.
Cannot resolve module ../Utilities/Platform.
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This PR is causing some headaches for some reason. I'm trying some git magic to put it all back together on top of master to be able to land it. |
hramos
removed
Import Started
Summary: Fixes facebook#18098 Pull Request resolved: facebook#21577 Differential Revision: D13761884 Pulled By: cpojer fbshipit-source-id: a096d69c589815d00754427fb575de0d8d0b595f
Fixes #18098
Test Plan:
Scrolling to the last section android
Scrolling to the last section ios
Scrolling to the section index 1, item index 0 android
Scrolling to the section index 1, item index 0 ios
Release Notes:
Changelog:
[IOS] [BUGFIX] [VirtualizedSectionList.js] - Changed indexing depending on platform to fix overscrolling.